-
Notifications
You must be signed in to change notification settings - Fork 2k
MSD: Introduce AppConfigSlug to replace DashboardType #108462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
ddec4e0 to
affa19f
Compare
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
| apps: boolean; | ||
| }; | ||
|
|
||
| export type AppConfigSlug = 'dotcom' | 'ciab' | ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the empty string and make dotcom the default?
p-jackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the idea of this PR, that the two dashboard flavours are dotcom/ciab, not msd/ciab.
But I do wish we didn't have to resort to a flag like this in the config. With #108277 and #108424 already merged though, it may be too late.
Heavy customisation based on "dashboard type" feels like we will eventually end up in a similar situation similar to our onboarding flows: where there are many permutations of appearance and copy based on magic string comparisons.
Part of #108277, #108424
Proposed Changes
slugproperty to the app config. The value should be eitherdotcomandciabDashboardTypewith theAppConfigSlug, and get the value from the app context directlyWhy are these changes being made?
slugof the app instead of the dashboard type.Testing Instructions
dashboard=dotcomin the URLdashboard=ciabin the URLPre-merge Checklist