Skip to content

Conversation

@arthur791004
Copy link
Contributor

Part of #108277, #108424

Proposed Changes

  • Add the slug property to the app config. The value should be either dotcom and ciab
  • Replace the DashboardType with the AppConfigSlug, and get the value from the app context directly

Why are these changes being made?

  • Both dashboard-dotcom and dashboard-ciab are the multi-site dashboard (MSD). The name of the MSD should depend on the slug of the app instead of the dashboard type.

Testing Instructions

  • Go to /domains
  • Click Add domain name > Search domain names
  • Ensure you can see the dashboard=dotcom in the URL
  • Go to /ciab/domains
  • Click Add domain name > Search domain names
  • Ensure you can see the dashboard=ciab in the URL

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Feb 2, 2026
@arthur791004 arthur791004 requested a review from zaguiini February 2, 2026 08:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2026
@arthur791004 arthur791004 marked this pull request as ready for review February 2, 2026 08:39
@arthur791004 arthur791004 requested a review from a team as a code owner February 2, 2026 08:39
@arthur791004 arthur791004 force-pushed the feat/msd-add-slug-to-config branch from ddec4e0 to affa19f Compare February 2, 2026 08:40
@arthur791004 arthur791004 requested a review from a team as a code owner February 2, 2026 08:40
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/msd-add-slug-to-config on your sandbox.

apps: boolean;
};

export type AppConfigSlug = 'dotcom' | 'ciab' | '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the empty string and make dotcom the default?

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea of this PR, that the two dashboard flavours are dotcom/ciab, not msd/ciab.

But I do wish we didn't have to resort to a flag like this in the config. With #108277 and #108424 already merged though, it may be too late.

Heavy customisation based on "dashboard type" feels like we will eventually end up in a similar situation similar to our onboarding flows: where there are many permutations of appearance and copy based on magic string comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants